Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc building via run build_package #553

Merged
merged 2 commits into from
May 3, 2023

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented May 2, 2023

Current pinnings in the requirements.txt for doc builds could not be satisfied (CuPy 9.3 appears to no longer be available on PyPI).

The key changes to those requirements are:
1.) use newer CuPy
2.) bump numpy to a version supported by CuPy
3.) bump sphinx to 4.5 so it is compatible with recent jinja2
4.) relax most other pinnings

A separate commit fixes several broken links discovered by the link checker during the doc builds.

Must update CuPy (9.x too old)
Updated CuPy requires a newer NumPy version
Sphinx 4.x required for compatibility with latest jinja2
relax pinning on most other packages to allow compatible versions to be found
@grlee77 grlee77 added doc Improvements or additions to documentation non-breaking Introduces a non-breaking change labels May 2, 2023
@grlee77 grlee77 requested a review from a team as a code owner May 2, 2023 21:46
Copy link
Contributor

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for updating links and typos!

@grlee77
Copy link
Contributor Author

grlee77 commented May 3, 2023

/merge

@rapids-bot rapids-bot bot merged commit 00c45c6 into rapidsai:branch-23.06 May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants