Allow numpy 1.24. #563
Merged
Allow numpy 1.24. #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
added
improvement
|
The SHA256 failures here are related to a recent change in the skimage 0.19 seems to not handle this properly. It downloads the new version, but compares it with the old hash value. skimage 0.20 downloads the older version so the old hash value check passes. for upcoming skimage 0.21 it will download the new version and pass with the new hash value. Two possible workarounds for cuCIM are: |
grlee77
approved these changes
May 31, 2023
|
Great. Once #564 is merged, feel free to update this PR with |
rapids-bot bot
pushed a commit
that referenced
this pull request
May 31, 2023
Due to a [recent change in the eagle image](https://gitlab.com/scikit-image/data/-/merge_requests/22) used in one of our test cases, skimage 0.19 fails to load it. As a solution, we can just restrict this one test to run only for `scikit-image>=0.20`. Should resolve test failures seen in #563 Authors: - Gregory Lee (https://github.com/grlee77) Approvers: - Bradley Dice (https://github.com/bdice) - https://github.com/jakirkham URL: #564
jakirkham
approved these changes
May 31, 2023
|
/merge |
|
Thanks all! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the upper bound on
numpy<1.24to allow newer NumPy versions.