Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve memory leak check stability in test_read_region_cpu_memleak test #623

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Improve memory leak check stability in test_read_region_cpu_memleak test #623

merged 1 commit into from
Oct 31, 2023

Conversation

gigony
Copy link
Contributor

@gigony gigony commented Oct 31, 2023 •
edited
Loading

There is a case where memory usage check is not stable enough:
#620 (comment)

Instead of choosing index 1 and 4 (among 5 samples), choose 5 and 9 (among 10 samples) for memory leak check.

Fixes #625

@gigony
Improve memory leak check stability
fd4c525 
- Instead of choosing index 1 and 4, choose 5 and 9
  for memory leak check.

Signed-off-by: Gigon Bae <gbae@nvidia.com>
@gigony gigony self-assigned this Oct 31, 2023
@gigony gigony requested a review from a team as a code owner October 31, 2023 18:28
@gigony gigony added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Oct 31, 2023
grlee77
grlee77 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@grlee77 grlee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, Gigon

@grlee77 grlee77 mentioned this pull request Oct 31, 2023
Merged
@grlee77
Copy link
Contributor

grlee77 commented Oct 31, 2023

/Merge

@grlee77
Copy link
Contributor

grlee77 commented Oct 31, 2023

/merge

@rapids-bot rapids-bot bot merged commit 6d5b874 into rapidsai:branch-23.12 Oct 31, 2023
26 checks passed
@gigony gigony mentioned this pull request Nov 14, 2023
Closed
@jakirkham jakirkham added this to the v23.12.00 milestone Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grlee77 grlee77 grlee77 approved these changes

Assignees

@gigony gigony

Labels
improvement Improves an existing functionality maintenance non-breaking Introduces a non-breaking change
Projects
cucim
Status: Done
Milestone
v23.12.00
Development

Successfully merging this pull request may close these issues.

Intermittent test failure: test_read_region_cpu_memleak[testimg_tiff_stripe_4096×4096_256_deflate]
3 participants
@gigony @grlee77 @jakirkham