Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor CUDA versions in dependencies.yaml #671

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#7.

Proposes splitting the cuda-version dependency in dependencies.yaml out to its own thing, separate from the bits of the CUDA Toolkit this project needs.

Benefits of this change

  • prevents accidental inclusion of multiple cuda-version version in environments
  • reduces update effort (via enabling more use of globs like "12.*")
  • improves the chance that errors like "conda recipe is missing a dependency" are caught in CI

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks James! 🙏

Had one question below

dependencies.yaml Outdated Show resolved Hide resolved
@jameslamb jameslamb requested a review from jakirkham January 11, 2024 15:42
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks James! 🙏

@jakirkham jakirkham added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 11, 2024
@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit a3c0f13 into rapidsai:branch-24.02 Jan 11, 2024
39 checks passed
@jameslamb jameslamb mentioned this pull request Jan 11, 2024
@jameslamb jameslamb deleted the rework-dependencies branch January 11, 2024 19:33
rapids-bot bot pushed a commit that referenced this pull request Feb 9, 2024
* switches to CUDA 12.2.2 for building conda packages and wheels
* adds new tests running against CUDA 12.2.2
* removes some unnecessary `cuda-version={major}.{minor}` stuff in `dependencies.yaml` that was missed in #671 

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7
* rapidsai/shared-workflows#166

Planning a second round of PRs to revert these references back to a proper `branch-24.{nn}` release branch of `shared-workflows` once rapidsai/shared-workflows#166 is merged.

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)
  - https://github.com/jakirkham
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)
  - Bradley Dice (https://github.com/bdice)
  - https://github.com/jakirkham

URL: #672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants