Fix docs upload directory #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raydouglass
added
bug
ajschmidt8
approved these changes
Mar 25, 2024
AyodeAwe
approved these changes
Mar 25, 2024
|
/merge |
ajschmidt8
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Looks good. Though there is nothing currently preventing an accident like this from happening again.
I'm thinking we should add the following two checks in this function:
- check to see if the
RAPIDS_VERSION_NUMBERvariable matches a0.38or24.06regex pattern - check to see whether each HTML directory has an
index.htmlfile
That will help ensure that we don't upload any faulty doc versions or directories.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-24.04 #714 +/- ##
================================================
- Coverage 93.57% 93.57% -0.01%
================================================
Files 130 130
Lines 10009 10007 -2
================================================
- Hits 9366 9364 -2
Misses 643 643 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to rapidsai/cudf#15291, fixes the upload directory for docs (
24.04.00a30=>24.04).