Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removal of deprecated functions/kwargs scheduled for release 24.06 #724

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Apr 16, 2024

This MR completes a few scheduled deprecations

  • removes renamed get_xyz_coords function (it already wasn't accessible from the top-level cucim.skimage.color namespace)
  • removes deprecated return_error kwarg from phase_cross_correlation (error is always returned)
  • removes deprecated random_state kwarg from medial_axis (it was renamed to rng previously)

…4.06

- remove get_xyz_coords function
- remove return_error kwarg to phase_cross_correlation (error is always returned)
- remove random_state kwarg from medial_axis (renamed to rng)

Signed-off-by: Gregory Lee <grlee77@gmail.com>
@grlee77 grlee77 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change maintenance labels Apr 16, 2024
@grlee77 grlee77 added this to the v24.06 milestone Apr 16, 2024
@grlee77 grlee77 requested a review from a team as a code owner April 16, 2024 19:33
Copy link
Contributor

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grlee77 for this update!
Looks good to me!

@grlee77
Copy link
Contributor Author

grlee77 commented Apr 18, 2024

/merge

@rapids-bot rapids-bot bot merged commit 16d015b into rapidsai:branch-24.06 Apr 18, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality maintenance non-breaking Introduces a non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants