Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump scikit-image upper bound (allow 0.24.x) #769

Merged
merged 3 commits into from
Aug 22, 2024
Merged

bump scikit-image upper bound (allow 0.24.x) #769

merged 3 commits into from
Aug 22, 2024

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Aug 22, 2024 •
edited by jakirkham
Loading

Fixes #768

@grlee77 grlee77 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Aug 22, 2024
@grlee77 grlee77 added this to the v24.10.00 milestone Aug 22, 2024
@grlee77 grlee77 requested review from a team as code owners August 22, 2024 21:08
@grlee77 grlee77 requested a review from jameslamb August 22, 2024 21:08
@jakirkham
Copy link
Member

Thanks Greg! 🙏

Could you please also update these?

cucim/conda/recipes/cucim/meta.yaml

Line 68 in de6bfbb

- scikit-image >=0.19.0,<0.23.0a0

cucim/conda/recipes/cucim/meta.yaml

Line 82 in de6bfbb

- scikit-image >=0.19.0,<0.23.0a0

@jakirkham
Copy link
Member

Went ahead and pushed the suggested change above. Hope that is ok 🙂

jakirkham
jakirkham approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Greg! 🙏

Confirmed this gets all of the scikit-image requirements up-to-date

Greg and I also discussed offline if code changes were needed as part of this update. We determined no we can just update the dependency without issues

So this is all we need for scikit-image 0.24.0

Approving so we can get this in

@jakirkham
Copy link
Member

/merge

@jakirkham jakirkham mentioned this pull request Aug 22, 2024
Merged
@rapids-bot rapids-bot bot merged commit a59be4f into rapidsai:branch-24.10 Aug 22, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

@jameslamb jameslamb Awaiting requested review from jameslamb jameslamb is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees

@jakirkham jakirkham

Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
cucim
Status: Done
Milestone
v24.10.00
Development

Successfully merging this pull request may close these issues.

Upgrading to scikit-image 0.24.0
2 participants
@grlee77 @jakirkham