Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #773

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#40

This PR adds support for Python 3.12.

Notes for Reviewers

This is part of ongoing work to add Python 3.12 support across RAPIDS.
It temporarily introduces a build/test matrix including Python 3.12, from rapidsai/shared-workflows#213.

A follow-up PR will revert back to pointing at the branch-24.10 branch of shared-workflows once all
RAPIDS repos have added Python 3.12 support.

This will fail until all dependencies have been updates to Python 3.12

CI here is expected to fail until all of this project's upstream dependencies support Python 3.12.

This can be merged whenever all CI jobs are passing.

@jameslamb jameslamb added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Sep 4, 2024
@jameslamb jameslamb changed the title Add support for Python 3.12 WIP: Add support for Python 3.12 Sep 4, 2024
@jameslamb jameslamb changed the title WIP: Add support for Python 3.12 Add support for Python 3.12 Sep 4, 2024
@jameslamb jameslamb marked this pull request as ready for review September 4, 2024 23:59
@jameslamb jameslamb requested review from a team as code owners September 4, 2024 23:59
@jameslamb jameslamb requested review from raydouglass and bdice and removed request for raydouglass September 4, 2024 23:59
@bdice
Copy link
Contributor

bdice commented Sep 5, 2024

/merge

@rapids-bot rapids-bot bot merged commit 87c3320 into rapidsai:branch-24.10 Sep 5, 2024
45 checks passed
@jameslamb jameslamb deleted the python-3.12 branch September 5, 2024 18:35
rapids-bot bot pushed a commit that referenced this pull request Sep 6, 2024
While adding support for Python 3.12 in #773, we found a problem where `GPUtil` does not support Python 3.12 (#775).

This PR removes the dependency on `GPUtil` and replaces it with `cupy`, which is already a dependency.

Closes #775. Closes #776.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - Gregory Lee (https://github.com/grlee77)
  - Gigon Bae (https://github.com/gigony)

URL: #777
@jakirkham jakirkham added this to the v24.10.00 milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants