Skip to content

Commit

Permalink
Drop {{ pin_compatible('numpy', max_pin='x') }} (#16301)
Browse files Browse the repository at this point in the history
Part of issue: rapidsai/build-planning#82

Drop `{{ pin_compatible('numpy', max_pin='x') }}` as it is no longer needed. `numpy` has its own `run_exports`, which constraints `numpy` to an API compatible version. More details in issue: https://github.com/orgs/rapidsai/projects/132

So `cudf` now uses that in its recipe builds. Also update `requirements/run` to set the `numpy` lower bound to `1.23` as required by us.

Lastly add todo comments for NumPy 2 update lines.

Authors:
  - https://github.com/jakirkham

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #16301
  • Loading branch information
jakirkham authored Jul 18, 2024
1 parent faddc8c commit c6c21d7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 3 additions & 1 deletion conda/recipes/cudf/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ requirements:
- rapids-build-backend >=0.3.0,<0.4.0.dev0
- scikit-build-core >=0.7.0
- dlpack >=0.8,<1.0
# TODO: Change to `2.0` for NumPy 2
- numpy 1.23
- pyarrow ==16.1.0.*
- libcudf ={{ version }}
Expand All @@ -82,7 +83,8 @@ requirements:
- pandas >=2.0,<2.2.3dev0
- cupy >=12.0.0
- numba >=0.57
- {{ pin_compatible('numpy', max_pin='x') }}
# TODO: Update `numpy` in `host` when dropping `<2.0a0`
- numpy >=1.23,<2.0a0
- {{ pin_compatible('pyarrow', max_pin='x.x') }}
- libcudf ={{ version }}
- {{ pin_compatible('rmm', max_pin='x.x') }}
Expand Down
2 changes: 2 additions & 0 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,7 @@ dependencies:
packages:
# Hard pin the patch version used during the build.
# Sync with conda build constraint & wheel run constraint.
# TODO: Change to `2.0.*` for NumPy 2
- numpy==1.23.*
build_python_cudf:
common:
Expand Down Expand Up @@ -551,6 +552,7 @@ dependencies:
- output_types: [conda, requirements, pyproject]
packages:
- fsspec>=0.6.0
# TODO: Update `numpy` in `build_python_common` when dropping `<2.0a0`
- numpy>=1.23,<2.0a0
- pandas>=2.0,<2.2.3dev0
run_cudf:
Expand Down

0 comments on commit c6c21d7

Please sign in to comment.