-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Add overloads for row comparator that automatically handle comparisons between rows of a table with a scalar #10892
Comments
Reference: #10883 (comment) |
This issue depends on #10893 |
This issue has been labeled |
This should be worked on. Without a comparator for tables/columns and scalars, lifetime management of a column derived from the scalar gets very awkward. cudf/cpp/src/lists/contains.cu Lines 251 to 268 in ee15d1c
I commented here:
|
Note that this issue is relevant not just for equality comparison but for lexicographic comparison. Usage of that case can be binary searching or many other comparison cases involving scalar. |
This issue has been labeled |
Sometimes, we want to compare rows of a table with a single element given as a scalar. In order to do that, at the caller site, we have to convert the scalar into a column of one row, then convert that column into a table, then pass both tables into the comparator. This is repetitive and tedious.
We should add overloads for the row comparator that can automatically do this. The caller just needs to pass in the input table and input scalar.
The text was updated successfully, but these errors were encountered: