-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Create column_view
of one row out of scalar
#10893
Comments
This would only work for non-compound types. You still have to create the offsets buffer for a strings or list column. The |
That is implementation details, I did that in my draft PR: returning |
I disagree with this. What does this save over building a column? |
But what if the scalar is nested type with a lot of data? Creating a new column will copy all data over. On the other hand, just creating a |
I believe each nested layer in a lists column has a unique set of offsets, right? |
This is a good point. I didn't think about the fact that a |
In many operations such as searching/sorting etc, we may want to compare rows of a column with a scalar. Most of the time, we have to convert the input scalar into a column of one row. This is not trivial. For some scalar types such as string and list, we have to create an offsets buffer in memory for such conversion.
We should have internal APIs to support creating a
column_view
of one row that views the content of the input scalar as its (unique) row.The text was updated successfully, but these errors were encountered: