Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Should cudf.to_datetime(dayfirst=True) raise NotImplementedError? #14042

Closed
mroeschke opened this issue Sep 6, 2023 · 0 comments · Fixed by #14058
Closed

[BUG] Should cudf.to_datetime(dayfirst=True) raise NotImplementedError? #14042

mroeschke opened this issue Sep 6, 2023 · 0 comments · Fixed by #14058
Labels
bug Something isn't working Python Affects Python cuDF API.

Comments

@mroeschke
Copy link
Contributor

Describe the bug
Should cudf.to_datetime(dayfirst=True) raise NotImplementedError?

Steps/Code to reproduce bug

In [6]: cudf.to_datetime(["10-02-2014"], dayfirst=True)
Out[6]: DatetimeIndex(['2014-10-02'], dtype='datetime64[ns]')

Expected behavior

In [6]: cudf.to_datetime(["10-02-2014"], dayfirst=True)
Out[6]: DatetimeIndex(['2014-02-10'], dtype='datetime64[ns]')

In DatetimeIndex.__init__, this specifically raises a NotImplementedError

        if dayfirst is not False:
            raise NotImplementedError("dayfirst == True is not yet supported")

Environment overview (please complete the following information)

  • Environment location: Bare-metal
  • Method of cuDF install: conda
    • If method of install is [Docker], provide docker pull & docker run commands used

Environment details
Please run and paste the output of the cudf/print_env.sh script here, to gather any other relevant environment details

Additional context
Add any other context about the problem here.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. labels Sep 6, 2023
@github-project-automation github-project-automation bot moved this to In Progress in cuDF/Dask/Numba/UCX Sep 6, 2023
rapids-bot bot pushed a commit that referenced this issue Sep 15, 2023
…format (#14058)

Raises a `NotImplementedError` to avoid this incorrect behavior (which seems to actually not be implemented)

```python
In [6]: cudf.to_datetime(["10-02-2014"], dayfirst=True)
Out[6]: DatetimeIndex(['2014-10-02'], dtype='datetime64[ns]')
```

closes #14042

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #14058
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuDF/Dask/Numba/UCX Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Python Affects Python cuDF API.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant