Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] [JNI] Add recovery_mode option to Java_ai_rapids_cudf_Table_readJSON #14073

Closed
andygrove opened this issue Sep 8, 2023 · 0 comments · Fixed by #14078
Closed

[FEA] [JNI] Add recovery_mode option to Java_ai_rapids_cudf_Table_readJSON #14073

andygrove opened this issue Sep 8, 2023 · 0 comments · Fixed by #14078
Assignees
@andygrove
Labels
feature request New feature or request Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS

Comments

@andygrove
Copy link
Contributor

andygrove commented Sep 8, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
I would like to be able to specify the recovery mode as either RECOVER_WITH_NULL or FAIL when calling Table.readJSON from the Spark plugin.

Describe the solution you'd like
Add a new parameter to Java_ai_rapids_cudf_Table_readJSON (and the Java binding) and pass it through to the json_reader_options_builder. Given that there are only two options currently, I propose adding a boolean recover_with_null parameter.

Describe alternatives you've considered
None

Additional context
None
@andygrove andygrove added feature request New feature or request Needs Triage Need team to review and classify Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS labels Sep 8, 2023
@andygrove andygrove self-assigned this Sep 8, 2023
@github-project-automation github-project-automation bot moved this to In Progress in cuDF/Dask/Numba/UCX Sep 8, 2023
@andygrove andygrove mentioned this issue Sep 11, 2023
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Sep 12, 2023
@andygrove
[Java] Add recoverWithNull to JSONOptions and pass to Table.readJSON (#…
258e0fe 
…14078)

This PR exposes the recently added `json_reader_options_builder::recovery_mode` option in the JNI layer.


closes #14073

Authors:
  - Andy Grove (https://github.com/andygrove)
  - Nghia Truong (https://github.com/ttnghia)

Approvers:
  - Gera Shegalov (https://github.com/gerashegalov)
  - Robert (Bobby) Evans (https://github.com/revans2)
  - Raza Jafri (https://github.com/razajafri)
  - Nghia Truong (https://github.com/ttnghia)

URL: #14078
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuDF/Dask/Numba/UCX Sep 12, 2023
@bdice bdice removed the Needs Triage Need team to review and classify label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andygrove andygrove

Labels
feature request New feature or request Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Java] Add recoverWithNull to JSONOptions and pass to Table.readJSON andygrove/cudf
2 participants
@andygrove @bdice