Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] DataFrame constructor should disallow iterable of DataFrames #14094

Closed
mroeschke opened this issue Sep 12, 2023 · 0 comments · Fixed by #14118
Closed

[BUG] DataFrame constructor should disallow iterable of DataFrames #14094

mroeschke opened this issue Sep 12, 2023 · 0 comments · Fixed by #14118
Assignees
@galipremsagar
Labels
bug Something isn't working Python Affects Python cuDF API.

Comments

@mroeschke
Copy link
Contributor

Describe the bug
DataFrame should disallow iterable of DataFrames. I don't think it's well defined what a DataFrame element should represent

Steps/Code to reproduce bug

In [26]: cudf.DataFrame([cudf.DataFrame(range(2))])
Out[26]: 
   0
0  0

In [27]: pandas.DataFrame([pandas.DataFrame(range(2))])
ValueError: Must pass 2-d input. shape=(1, 2, 1)

Expected behavior
cudf should also raise a ValueError possibly

Environment overview (please complete the following information)

  • Environment location: Bare-metal
  • Method of cuDF install: conda
@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. labels Sep 12, 2023
@galipremsagar galipremsagar self-assigned this Sep 18, 2023
@galipremsagar galipremsagar mentioned this issue Sep 18, 2023
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Sep 18, 2023
@galipremsagar
Restrict iterables of DataFrame's as input to DataFrame construct…
4467066 
…or (#14118)

Fixes: #14094 
This PR raises an error when an iterates of `DataFrame`'s is detected in `DataFrame` constructor.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Matthew Roeschke (https://github.com/mroeschke)

URL: #14118
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuDF/Dask/Numba/UCX Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galipremsagar galipremsagar

Labels
bug Something isn't working Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restrict iterables of DataFrame's as input to DataFrame constructor galipremsagar/cudf
2 participants
@mroeschke @galipremsagar