[FEA] Refactor Column/NamedColumn split in cudf-polars #16272
Assignees
Labels
0 - Backlog
In queue waiting for assignment
cudf.polars
Issues specific to cudf.polars
feature request
New feature or request
Comments
wence-
added
feature request
wence-
added a commit
to wence-/cudf
that referenced
this issue
Aug 29, 2024
This returns a pylibcudf column, so no metadata, which is awkward. We will change that when rapidsai#16272 is fixed.
wence-
added a commit
to wence-/cudf
that referenced
this issue
Sep 2, 2024
This returns a pylibcudf column, so no metadata, which is awkward. We will change that when rapidsai#16272 is fixed.
wence-
added a commit
to wence-/cudf
that referenced
this issue
Oct 1, 2024
Everything in the expression evaluation now operates on columns without names. DataFrame construction takes either a mapping from string-valued names to columns, or a sequence of pairs of names and columns. This removes some duplicate code in the NamedColumn class (by removing it) where we had to fight the inheritance hierarchy. - Closes rapidsai#16272
wence-
added a commit
to wence-/cudf
that referenced
this issue
Oct 1, 2024
Everything in the expression evaluation now operates on columns without names. DataFrame construction takes either a mapping from string-valued names to columns, or a sequence of pairs of names and columns. This removes some duplicate code in the NamedColumn class (by removing it) where we had to fight the inheritance hierarchy. - Closes rapidsai#16272
wence-
added a commit
to wence-/cudf
that referenced
this issue
Oct 1, 2024
Everything in the expression evaluation now operates on columns without names. DataFrame construction takes either a mapping from string-valued names to columns, or a sequence of pairs of names and columns. This removes some duplicate code in the NamedColumn class (by removing it) where we had to fight the inheritance hierarchy. - Closes rapidsai#16272
wence-
added a commit
to wence-/cudf
that referenced
this issue
Oct 1, 2024
Everything in the expression evaluation now operates on columns without names. DataFrame construction takes either a mapping from string-valued names to columns, or a sequence of pairs of names and columns. This removes some duplicate code in the NamedColumn class (by removing it) where we had to fight the inheritance hierarchy. - Closes rapidsai#16272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently NamedColumn inherits from Column, however, because the constructor of the former takes an additional (required) argument, parent class factory methods that return
Selfcannot be used for the child class.This is painful because it means that we must replicate the code: one can't even do
super().blabecause if that constructs aSelfit will have a name missing.Really, named columns only appears when constructing dataframes: when evaluating expressions, the column can safely drop the name.
In the expression evaluator, the only place a namedcolumn appears is when evaluating a
Colexpression (which pulls a column out of a dataframe). But at that point, we could drop the name.This suggests that we shouldn't have that a
NamedColumnis-aColumn, but rather aNamedColumnhas-aColumn(and a name).The text was updated successfully, but these errors were encountered: