-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Upgrade pandas
to 1.5
#11617
[REVIEW] Upgrade pandas
to 1.5
#11617
Conversation
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment -- thanks, Prem!
…into pandas_1.5.x
result_col = column.column_empty( | ||
len(self._column), dtype="bool", masked=True | ||
raise TypeError( | ||
f"expected a string or a sequence-like object, not " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, in 1.5. we also further restricted startswith
/endswith
to only accept a tuple specifically to mirror the stdlib
In [15]: "f".endswith(["f", "g"])
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
Input In [15], in <cell line: 1>()
----> 1 "f".endswith(["f", "g"])
TypeError: endswith first arg must be str or a tuple of str, not list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did see that change, I'll be opening a follow-up PR because that will need some discussions & libcudf side changes too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks for this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gpucibot merge |
Description
This PR introduces
pandas-1.5
support incudf
. The changes include:group_keys
support ingroupby
fordask_cudf
to work: Add support forgroup_keys
ingroupby
#11659zfill
updates to matchpandas-1.5
behavior: Update zfill to match Python output #11634where
API: Ability to inspect a scalar value if it can be fit into the existing dtype, similar to: DOC: Clarify DataFrame.where tries to maintain dtype of DataFrame when providing fill_value pandas-dev/pandas#48373ValueError
toTypeError
when an unknown category is being set to aCategoricalColumn
ArrowIntervalType
related import that has resulted incudf
to error on import itself.IntervalColumn.to_pandas
.boolean
dtype is being set to aNumericalColumn
.pat
is None inSeries.str.startswith
&Series.str.endswith
.IntervalDtype.to_pandas
with appropriate versioning.get_window_bounds
signature changes.Checklist