Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Upgrade pandas to 1.5 #11617

Merged
merged 43 commits into from
Sep 21, 2022

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Aug 29, 2022

Description

This PR introduces pandas-1.5 support in cudf. The changes include:

branch-22.10:

== 4275 failed, 79837 passed, 2049 skipped, 1193 xfailed, 1923 xpassed, 6597 warnings, 4 errors in 1103.52s (0:18:23) ==
== 803 failed, 106 passed, 14 skipped, 14 xfailed, 324 warnings, 17 errors in 148.46s (0:02:28) ==

This PR:

== 84041 passed, 2049 skipped, 1199 xfailed, 1710 xpassed, 6599 warnings in 359.27s (0:05:59) ==
== 954 passed, 14 skipped, 7 xfailed, 3 xpassed, 580 warnings in 54.75s ==

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added conda Python Affects Python cuDF API. labels Aug 29, 2022
@galipremsagar galipremsagar added 2 - In Progress Currently a work in progress 5 - DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function and removed Python Affects Python cuDF API. conda labels Aug 29, 2022
@galipremsagar galipremsagar self-assigned this Aug 29, 2022
@github-actions github-actions bot added conda Python Affects Python cuDF API. labels Aug 29, 2022
python/cudf/setup.py Outdated Show resolved Hide resolved
@vyasr vyasr mentioned this pull request Sep 1, 2022
3 tasks
ci/cpu/build.sh Outdated Show resolved Hide resolved
ci/gpu/build.sh Outdated Show resolved Hide resolved
conda/environments/cudf_dev_cuda11.5.yml Outdated Show resolved Hide resolved
conda/environments/cudf_dev_cuda11.5.yml Outdated Show resolved Hide resolved
conda/recipes/cudf/meta.yaml Outdated Show resolved Hide resolved
python/cudf/cudf/core/_compat.py Outdated Show resolved Hide resolved
galipremsagar and others added 2 commits September 20, 2022 10:27
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@galipremsagar galipremsagar added breaking Breaking change and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels Sep 20, 2022
Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment -- thanks, Prem!

result_col = column.column_empty(
len(self._column), dtype="bool", masked=True
raise TypeError(
f"expected a string or a sequence-like object, not "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, in 1.5. we also further restricted startswith/endswith to only accept a tuple specifically to mirror the stdlib

In [15]: "f".endswith(["f", "g"])
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Input In [15], in <cell line: 1>()
----> 1 "f".endswith(["f", "g"])

TypeError: endswith first arg must be str or a tuple of str, not list

Copy link
Contributor Author

@galipremsagar galipremsagar Sep 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did see that change, I'll be opening a follow-up PR because that will need some discussions & libcudf side changes too.

Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks for this!

Copy link
Contributor

@msadang msadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ci/gpu/build.sh Outdated Show resolved Hide resolved
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Sep 20, 2022
ci/gpu/build.sh Outdated Show resolved Hide resolved
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 387c5ff into rapidsai:branch-22.10 Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants