Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable sccache for Jenkins builds #12297

Merged
merged 3 commits into from
Dec 2, 2022
Merged

Re-enable sccache for Jenkins builds #12297

merged 3 commits into from
Dec 2, 2022

Conversation

ajschmidt8
Copy link
Member

@ajschmidt8 ajschmidt8 commented Dec 2, 2022 •
edited
Loading

Description

This PR re-adds some environment variables to the Jenkins scripts that are missing from the Jenkins CI images in order to re-enable sccache. These were accidentally removed in #12002.

All of these Jenkins scripts will be removed once Jenkins is disabled.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@ajschmidt8
Use separate SCCACHE_S3_KEY_PREFIX for Jenkins vs. GH Actions
3d37d5c 
It seems that Jenkins and GH Action builds run slower when they use the same `SCCACHE_S3_KEY_PREFIX` value.

This PR updates the Jenkins build scripts to patch the `SCCACHE_S3_KEY_PREFIX` value so that it's unique for Jenkins builds vs. GitHub Action builds.

All of these Jenkins scripts will be removed once Jenkins is disabled.
@github-actions github-actions bot added the ci label Dec 2, 2022
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 2, 2022
@ajschmidt8 ajschmidt8 changed the title Use separate SCCACHE_S3_KEY_PREFIX for Jenkins vs. GH Actions Re-enable sccache for Jenkins builds Dec 2, 2022
@ajschmidt8 ajschmidt8 marked this pull request as ready for review December 2, 2022 23:22
@ajschmidt8 ajschmidt8 requested a review from a team as a code owner December 2, 2022 23:22
msadang
msadang approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@msadang msadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sccache changes look good

@ajschmidt8 ajschmidt8 merged commit 9682fca into rapidsai:branch-23.02 Dec 2, 2022
@ajschmidt8 ajschmidt8 deleted the sccache-key branch December 2, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@msadang msadang msadang approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajschmidt8 @bdice @msadang