Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Unpin dask and distributed for development #12710

Merged
merged 3 commits into from
Feb 10, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

This PR unpins dask and distributed for 23.04 development.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@0cab19a). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head ea410e5 differs from pull request most recent head e340141. Consider uploading reports for the commit e340141 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.04   #12710   +/-   ##
===============================================
  Coverage                ?   85.81%           
===============================================
  Files                   ?      158           
  Lines                   ?    25153           
  Branches                ?        0           
===============================================
  Hits                    ?    21586           
  Misses                  ?     3567           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdice bdice mentioned this pull request Feb 6, 2023
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in rapidsai/dask-cuda#1110: just to be sure, nothing has changed w.r.t. the procedure, right? We still need to wait for the actual 23.02 to release before merging this, otherwise forward merge will revert this change. Blocking for now, but please correct me if anything has changed and this can be merged immediately.

@galipremsagar galipremsagar added 5 - DO NOT MERGE Hold off on merging; see PR for details and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels Feb 6, 2023
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @galipremsagar !

rapids-bot bot pushed a commit to rapidsai/dask-cuda that referenced this pull request Feb 10, 2023
This PR unpins `dask` and `distributed` for `23.04` development.


xref: rapidsai/cudf#12710

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Ray Douglass (https://github.com/raydouglass)

URL: #1110
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Feb 10, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 048f936 into rapidsai:branch-23.04 Feb 10, 2023
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Feb 11, 2023
This PR unpins `dask` and `distributed` for `23.04` development.



xref : rapidsai/cudf#12710

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #5209
rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Feb 11, 2023
This PR unpins `dask` and `distributed` for `23.04` development.



xref: rapidsai/cudf#12710

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #1253
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Feb 13, 2023
This PR unpins `dask` and `distributed` for `23.04` development.


xref: rapidsai/cudf#12710

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Brad Rees (https://github.com/BradReesWork)

URL: #3243
AyodeAwe pushed a commit to AyodeAwe/cuml that referenced this pull request Feb 13, 2023
This PR unpins `dask` and `distributed` for `23.04` development.



xref : rapidsai/cudf#12710

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#5209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants