Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject functions without bytecode from _can_be_jitted in GroupBy Apply #13429

Merged
merged 6 commits into from
May 25, 2023
Merged

Reject functions without bytecode from _can_be_jitted in GroupBy Apply #13429

merged 6 commits into from
May 25, 2023

Conversation

brandon-b-miller
Copy link
Contributor

Closes #13426

@brandon-b-miller brandon-b-miller added bug Something isn't working numba Numba issue non-breaking Non-breaking change python labels May 24, 2023
@brandon-b-miller brandon-b-miller self-assigned this May 24, 2023
@brandon-b-miller brandon-b-miller requested a review from a team as a code owner May 24, 2023 13:50
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 24, 2023
bdice
bdice reviewed May 24, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for the case in the issue this closes? We should not allow a regression that breaks past behavior even if it falls back to the old implementation.

@brandon-b-miller
Copy link
Contributor Author

Can we add a test for the case in the issue this closes? We should not allow a regression that breaks past behavior even if it falls back to the old implementation.

What do you think of the test added in 5163357 ?

@brandon-b-miller brandon-b-miller requested a review from bdice May 25, 2023 20:12
@brandon-b-miller
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5b3e3ab into rapidsai:branch-23.08 May 25, 2023
@sarahyurick sarahyurick mentioned this pull request May 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@bdice bdice bdice approved these changes

Assignees

@brandon-b-miller brandon-b-miller

Labels
bug Something isn't working non-breaking Non-breaking change numba Numba issue Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] groupby apply on a functools.partial func fails
3 participants
@brandon-b-miller @bdice @mroeschke