Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parquet pytest failures with pandas-2.0 #13474

Merged
merged 1 commit into from
May 31, 2023
Merged

Fix parquet pytest failures with pandas-2.0 #13474

merged 1 commit into from
May 31, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

This PR fixes parquet pytest failures, mostly working around two upstream issues:

  1. BUG: read_parquet not preserving type of partition_cols pandas-dev/pandas#53345
  2. [Python] Support converting to non-nano datetime64 for pandas >= 2.0 apache/arrow#33321

Thus fixes 20 pytest failure:
This PR:

= 231 failed, 95767 passed, 2045 skipped, 764 xfailed, 300 xpassed in 426.65s (0:07:06) =

On pandas_2.0_feature_branch:

= 251 failed, 95747 passed, 2045 skipped, 764 xfailed, 300 xpassed in 433.50s (0:07:13) =

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels May 30, 2023
@galipremsagar galipremsagar self-assigned this May 30, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner May 30, 2023 22:04
@galipremsagar galipremsagar requested review from charlesbluca and removed request for a team May 30, 2023 22:04
@galipremsagar galipremsagar mentioned this pull request May 30, 2023
Closed
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels May 31, 2023
@galipremsagar galipremsagar merged commit a92ad86 into rapidsai:pandas_2.0_feature_branch May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @mroeschke