Use dev_string_lengths. #13991
Closed
Use dev_string_lengths. #13991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
commented
Aug 29, 2023
| @@ -2220,7 +2220,7 @@ std::unique_ptr<table> convert_from_rows(lists_column_view const &input, | |||
| std::vector<rmm::device_uvector<char>> string_data_cols; | |||
| std::vector<size_type *> string_col_offset_ptrs; | |||
| std::vector<char *> string_data_col_ptrs; | |||
| for (auto &col_string_lengths : string_lengths) { | |||
| for (auto &col_string_lengths : dev_string_lengths) { | |||
There was a problem hiding this comment.
@hyperbolic2346 On second thought, I'm not sure about this change. I think the string_lengths vector is a host vector of device pointers, so it seems like binding auto &col_string_lengths : string_lengths by value into the lambda tmp is actually just binding a device pointer by value into the lambda -- there's no issue with using that on device. It's awkward, yes, but this is probably correct with no changes. If you agree let's close this PR.
|
Discussed offline with @hyperbolic2346. This code is fine as-is. I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems like a device lambda is accessing a host
std::vectorwhen it should be accessing a device uvector instead.Checklist