-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the mr from the base fixture #14057
Conversation
There's something very strange happening here. I can remove all uses of the mr from the fixture, but removing the mr itself is causing a single test failure in a test that isn't otherwise modified in this PR and does not use the mr function. Furthermore, the test only fails on arm, and only for certain types. In the interest of debugging a minimal example, I'm going to revert just that part of this PR, merge it, and then debug the issue separately (will probably need to get access to an arm machine). It seems likely that the issue is not directly related to the mr, but is some other problem perhaps caused by somewhere that we're not initializing/tearing down/otherwise interacting with GTest improperly. |
/merge |
Description
This mr is just an alias for the current memory resource, so we don't really need it. This came up in #14010 (comment). This PR removes all uses of it, but does not actually remove the mr yet. That will be done in a follow-up (see #14057 (comment)).
Checklist