-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose libcudf filter expression in read_parquet #15028
Expose libcudf filter expression in read_parquet #15028
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me. Since this is a Cython-only change, I assume we have no tests for it? @vyasr What is the pylibcudf testing plan?
Going to go ahead and merge this one. The broader question of |
/merge |
I have no power here. |
The devcontainers build is failing, which blocks merge. I am working on a fix to libkvikio. |
Left a comment on the pylibcudf story issue about testing, feel free to respond there and continue that conversation. |
37ad3a7
to
b9c195f
Compare
b9c195f
to
a696ed2
Compare
Description
libcudf's parquet reader supports filtering rows of the input dataset based on a (restricted subset of) libcudf Expression. Previously this functionality was not exposed in Python-land, do so here.
Checklist