Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] Unpin numba<0.58 #15031

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

raydouglass
Copy link
Member

@raydouglass raydouglass commented Feb 12, 2024

I think unpinning numba in the conda recipe was just missed in #14616.

I discovered this issue trying to build the 24.02 release.

PRs & nightly builds are working because the rapidsai-nightly channel has an older version of pynvjitlink that supported numba>=0.57 whereas the rapidsai channel only has the latest version which pins to numba>=0.58.

@raydouglass raydouglass requested a review from a team as a code owner February 12, 2024 22:50
@github-actions github-actions bot added the conda label Feb 12, 2024
@raydouglass raydouglass changed the title Unpin numba<0.58 [HOTFIX] Unpin numba<0.58 Feb 12, 2024
@raydouglass raydouglass added bug Something isn't working non-breaking Non-breaking change labels Feb 12, 2024
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that this looks like an oversight.

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm terribly sorry, I knew this pinning could be a potential issue but it hadn't appeared in any error logs I had seen yet, so I hadn't prioritized it among other build/packaging fixes that were actively causing errors. I am planning to revisit several cudf pinnings (numpy, arrow, etc.) in 24.04 once I get a chance.

@jakirkham
Copy link
Member

cc @brandon-b-miller (for awareness)

@raydouglass raydouglass merged commit ac438c4 into rapidsai:branch-24.02 Feb 13, 2024
68 of 69 checks passed
@raydouglass raydouglass deleted the bugfix/numba-0.58 branch February 13, 2024 14:22
@jakirkham
Copy link
Member

Thanks all! 🙏

res-life pushed a commit to res-life/cudf that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants