-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace thrust::tuple
with cuda::std::tuple
#15089
Conversation
We want to move away from thrust types in API boundaries in favor of the more suited `cuda::std` types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
The check-style
CI failures can be fixed by following the formatting guidance.
The PR should be ready to merge once the style check passes and the headers are properly regrouped.
Hm I tried the pre-commit inside the cuda12-pip container Will see whether another container works better |
Weird. That should work. Maybe try to format manually:
|
@miscco I pushed a change resulting from |
@bdice we do replace Will close the PR for now. |
We want to move away from thrust types in API boundaries in favor of the more suited
cuda::std
types