Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a developer check for proxy objects #15956

Merged
merged 8 commits into from
Jun 11, 2024
Merged

Add a developer check for proxy objects #15956

merged 8 commits into from
Jun 11, 2024

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Jun 7, 2024 •
edited
Loading

Description

Closes #15864

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 requested a review from a team as a code owner June 7, 2024 20:28
@Matt711 Matt711 requested review from vyasr and bdice June 7, 2024 20:28
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Jun 7, 2024
@Matt711 Matt711 added non-breaking Non-breaking change cudf.pandas Issues specific to cudf.pandas 2 - In Progress Currently a work in progress feature request New feature or request and removed cudf.pandas Issues specific to cudf.pandas Python Affects Python cuDF API. non-breaking Non-breaking change 2 - In Progress Currently a work in progress labels Jun 7, 2024
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jun 7, 2024
@Matt711 Matt711 added the 3 - Ready for Review Ready for review by team label Jun 10, 2024
@Matt711 Matt711 requested a review from mroeschke June 10, 2024 21:25
vyasr
vyasr requested changes Jun 11, 2024
View reviewed changes
docs/cudf/source/developer_guide/cudf_pandas.md Outdated Show resolved Hide resolved
python/cudf/cudf/pandas/fast_slow_proxy.py Outdated Show resolved Hide resolved
@Matt711 Matt711 added the 4 - Needs Review Waiting for reviewer to review or respond label Jun 11, 2024
@Matt711
Copy link
Contributor Author

Matt711 commented Jun 11, 2024

/merge

@rapids-bot rapids-bot bot merged commit dfa79d4 into rapidsai:branch-24.08 Jun 11, 2024
75 checks passed
@Matt711 Matt711 mentioned this pull request Jun 13, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@mroeschke mroeschke Awaiting requested review from mroeschke

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond cudf.pandas Issues specific to cudf.pandas feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Add developer/private cudf.pandas API to check for proxy objects
3 participants
@Matt711 @vyasr @mroeschke