Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate lists/extract to pylibcudf #16071

Merged
merged 17 commits into from
Jul 10, 2024
Merged

Migrate lists/extract to pylibcudf #16071

merged 17 commits into from
Jul 10, 2024

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Jun 24, 2024 •
edited
Loading

Description

Apart of #15162

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 requested a review from a team as a code owner June 24, 2024 19:35
@Matt711 Matt711 requested review from wence- and lithomas1 June 24, 2024 19:35
@github-actions github-actions bot added Python Affects Python cuDF API. pylibcudf Issues specific to the pylibcudf package labels Jun 24, 2024
@Matt711 Matt711 added the non-breaking Non-breaking change label Jun 24, 2024
@Matt711 Matt711 marked this pull request as draft June 24, 2024 20:11
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jun 24, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Matt711 Matt711 added the feature request New feature or request label Jun 24, 2024
wence-
wence- reviewed Jun 25, 2024
View reviewed changes
python/cudf/cudf/_lib/pylibcudf/lists.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_lib/pylibcudf/lists.pyx Outdated Show resolved Hide resolved
@Matt711 Matt711 marked this pull request as ready for review June 28, 2024 16:17
@Matt711
Copy link
Contributor Author

Matt711 commented Jun 28, 2024

/ok to test

@Matt711 Matt711 mentioned this pull request Jul 2, 2024
Closed
@Matt711 Matt711 self-assigned this Jul 2, 2024
lithomas1
lithomas1 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@lithomas1 lithomas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this LGTM!

@Matt711
Copy link
Contributor Author

Matt711 commented Jul 10, 2024

/merge

@rapids-bot rapids-bot bot merged commit 261f911 into rapidsai:branch-24.08 Jul 10, 2024
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr left review comments

@wence- wence- wence- left review comments

@lithomas1 lithomas1 lithomas1 approved these changes

Assignees

@Matt711 Matt711

Labels
feature request New feature or request non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Matt711 @wence- @vyasr @lithomas1