-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libcudf compiler requirements in contributing doc #16103
Merged
rapids-bot
merged 5 commits into
rapidsai:branch-24.08
from
davidwendt:contrib-requirements
Jun 28, 2024
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2248fe7
Update libcudf compiler requirements in contributing doc
davidwendt 4545877
Merge branch 'branch-24.08' into contrib-requirements
davidwendt 007b4c1
update runtime version; remove driver version
davidwendt c40bf91
Merge branch 'branch-24.08' into contrib-requirements
davidwendt a71feb7
add cuda-compatibility link
davidwendt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still support older CUDA versions at runtime, we test 11.4 in our nightlies. We only require 11.8 for builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I realized that this was probably runtime after I pushed this up. Glad to get confirmation on that.
Should I change this to say
CUDA/GPU Runtime
perhaps? I think the driver version is still correct.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you can clarify this is runtime information. Driver version is still correct as far as I know, but we have discussed removing driver information because it is implied by the compatible CUDA versions — and it would be one less piece of information to track and update. Remove that driver information (and maybe add a link to a page like https://docs.nvidia.com/deploy/cuda-compatibility/) if you think that is reasonable.