Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stream param to stream compaction APIs #16295

Merged
merged 8 commits into from
Aug 7, 2024
Merged

Add stream param to stream compaction APIs #16295

merged 8 commits into from
Aug 7, 2024

Conversation

JayjeetAtGithub
Copy link
Contributor

@JayjeetAtGithub JayjeetAtGithub commented Jul 16, 2024 •
edited
Loading

Description

Add stream param to a bunch of stream compaction APIs.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jul 16, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jul 16, 2024
@JayjeetAtGithub JayjeetAtGithub added improvement Improvement / enhancement to an existing function breaking Breaking change labels Jul 16, 2024
@JayjeetAtGithub JayjeetAtGithub changed the title Add stream param to stream compaction APIs Add stream param to stream compaction APIs Jul 16, 2024
@JayjeetAtGithub JayjeetAtGithub changed the title Add stream param to stream compaction APIs [WIP] Add stream param to stream compaction APIs Jul 16, 2024
@JayjeetAtGithub JayjeetAtGithub changed the title [WIP] Add stream param to stream compaction APIs Add stream param to stream compaction APIs Jul 19, 2024
@JayjeetAtGithub JayjeetAtGithub marked this pull request as ready for review July 19, 2024 06:28
@JayjeetAtGithub JayjeetAtGithub requested a review from a team as a code owner July 19, 2024 06:28
@JayjeetAtGithub
Copy link
Contributor Author

/ok to test

davidwendt
davidwendt requested changes Jul 19, 2024
View reviewed changes
cpp/include/cudf/detail/stream_compaction.hpp Outdated Show resolved Hide resolved
cpp/tests/streams/stream_compaction_test.cpp Outdated Show resolved Hide resolved
@JayjeetAtGithub
Copy link
Contributor Author

/ok to test

@JayjeetAtGithub JayjeetAtGithub changed the title Add stream param to stream compaction APIs [WIP] Add stream param to stream compaction APIs Jul 20, 2024
davidwendt
davidwendt previously requested changes Jul 22, 2024
View reviewed changes
cpp/include/cudf/lists/detail/stream_compaction.hpp Outdated Show resolved Hide resolved
@JayjeetAtGithub JayjeetAtGithub changed the title [WIP] Add stream param to stream compaction APIs Add stream param to stream compaction APIs Jul 24, 2024
@vyasr
Copy link
Contributor

vyasr commented Jul 24, 2024

Can we move this to 24.10?

@JayjeetAtGithub JayjeetAtGithub changed the base branch from branch-24.08 to branch-24.10 July 24, 2024 23:48
@JayjeetAtGithub
Copy link
Contributor Author

Can we move this to 24.10?

Done

@JayjeetAtGithub
Copy link
Contributor Author

@rapidsai/cudf-cpp-codeowners I would like to get some reviews on this

@mhaseeb123
Copy link
Member

@JayjeetAtGithub please remove the keywords “fixes #13744” if this PR doesn’t fully fix the issue as the bot doesn’t recognize the “partially” keyword.

@davidwendt
Copy link
Contributor

davidwendt commented Aug 2, 2024 •
edited
Loading

Looks like you will need to update a JNI call
https://github.com/rapidsai/cudf/actions/runs/10087840369/job/27985255071?pr=16295#step:9:1523

cudf/java/src/main/native/src/TableJni.cpp

Lines 3917 to 3922 in a8a3670

cudf::distinct(*input,
keys_indices,
keep_option,
nulls_equal ? cudf::null_equality::EQUAL : cudf::null_equality::UNEQUAL,
cudf::nan_equality::ALL_EQUAL,
rmm::mr::get_current_device_resource());

@JayjeetAtGithub JayjeetAtGithub requested a review from a team as a code owner August 5, 2024 16:17
@github-actions github-actions bot added the Java Affects Java cuDF API. label Aug 5, 2024
@JayjeetAtGithub
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 3fd8783 into rapidsai:branch-24.10 Aug 7, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@ttnghia ttnghia ttnghia approved these changes

@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@davidwendt davidwendt Awaiting requested review from davidwendt

Assignees
No one assigned
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code.
Projects
cuDF/Dask/Numba/UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@JayjeetAtGithub @vyasr @mhaseeb123 @davidwendt @harrism @hyperbolic2346 @karthikeyann @ttnghia