Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs of the TPC-H derived examples #16423

Merged
merged 15 commits into from
Aug 9, 2024
Merged

Update docs of the TPC-H derived examples #16423

merged 15 commits into from
Aug 9, 2024

Conversation

JayjeetAtGithub
Copy link
Contributor

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jul 29, 2024
@JayjeetAtGithub JayjeetAtGithub marked this pull request as ready for review July 29, 2024 20:49
@JayjeetAtGithub JayjeetAtGithub requested a review from a team as a code owner July 29, 2024 20:49
@JayjeetAtGithub JayjeetAtGithub added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 29, 2024
srinivasyadav18
srinivasyadav18 reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@srinivasyadav18 srinivasyadav18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cpp/examples/tpch/datagen/datagen.sh Outdated Show resolved Hide resolved
karthikeyann
karthikeyann reviewed Aug 6, 2024
View reviewed changes
cpp/examples/tpch/datagen/datagen.sh Outdated Show resolved Hide resolved
cpp/examples/tpch/README.md Outdated Show resolved Hide resolved
karthikeyann
karthikeyann reviewed Aug 9, 2024
View reviewed changes
cpp/examples/tpch/README.md Show resolved Hide resolved
cpp/examples/tpch/datagen/datagen.sh Outdated Show resolved Hide resolved
@JayjeetAtGithub
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 8009dc8 into rapidsai:branch-24.10 Aug 9, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikeyann karthikeyann karthikeyann approved these changes

@srinivasyadav18 srinivasyadav18 Awaiting requested review from srinivasyadav18

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JayjeetAtGithub @karthikeyann @srinivasyadav18