Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework cudf::io::text::byte_range_info class member functions #16518

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Adds const declarations to appropriate member functions in class cudf::io::text::byte_range_info and moves the ctor implementation to .cpp file.
This helps with using the byte_range_info objects in const variables and inside of const functions.

Found while working on #15983

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 8, 2024
@davidwendt davidwendt self-assigned this Aug 8, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Aug 9, 2024
@davidwendt davidwendt marked this pull request as ready for review August 9, 2024 17:25
@davidwendt davidwendt requested a review from a team as a code owner August 9, 2024 17:25
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 7178bf2 into rapidsai:branch-24.10 Aug 13, 2024
79 checks passed
@davidwendt davidwendt deleted the mbs-byte-range-info branch August 13, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants