Ensure comparisons with pyints and integer series always succeed #16532
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Python integers are compared to a series of integers, the result can always be correctly defined no matter the values of the Python integer.
This was always a very mild issue. But with NumPy 2 behavior not upcasting the computation result type based on the value anymore, even things like:
would fail.
(Similar paths could be taken for other integer scalars, but there would be mostly nice for performance.)
N.B. NumPy/pandas also support exact comparisons when mixing e.g. uint64 and int64. This is another rare exception that cudf currently does not support.
Closes gh-16282
Checklist
Just as a note for reviewers. The later operator checks, need
other
to be fully coerced, so unfortunately can't deal with all operator special paths at the start.