Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use changed-files shared workflow #16713

Merged
merged 15 commits into from
Sep 26, 2024
Merged

Use changed-files shared workflow #16713

merged 15 commits into from
Sep 26, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented Aug 30, 2024 •
edited
Loading

Description

Contributes to rapidsai/build-planning#94

Depends on rapidsai/shared-workflows#239

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner August 30, 2024 21:49
@KyleFromNVIDIA KyleFromNVIDIA added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 30, 2024
@KyleFromNVIDIA KyleFromNVIDIA mentioned this pull request Aug 30, 2024
Merged
bdice
bdice approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with one suggestion for naming. This is nice, thank you for the follow-up.

.github/workflows/pr.yaml Outdated Show resolved Hide resolved
@vyasr vyasr mentioned this pull request Sep 3, 2024
Merged
3 tasks
@KyleFromNVIDIA KyleFromNVIDIA mentioned this pull request Sep 26, 2024
Merged
3 tasks
@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners September 26, 2024 16:09
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 26, 2024
@KyleFromNVIDIA KyleFromNVIDIA changed the base branch from branch-24.10 to branch-24.12 September 26, 2024 16:09
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue Java Affects Java cuDF API. cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars pylibcudf Issues specific to the pylibcudf package labels Sep 26, 2024
@KyleFromNVIDIA KyleFromNVIDIA removed libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue Java Affects Java cuDF API. cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars pylibcudf Issues specific to the pylibcudf package labels Sep 26, 2024
@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 40075f1 into rapidsai:branch-24.12 Sep 26, 2024
102 checks passed
copy-pr-bot bot pushed a commit that referenced this pull request Sep 28, 2024
@KyleFromNVIDIA @lamarrr
Use changed-files shared workflow (#16713)
065b232 
Contributes to rapidsai/build-planning#94

Depends on rapidsai/shared-workflows#239

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - GALI PREM SAGAR (https://github.com/galipremsagar)

URL: #16713
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@bdice bdice bdice approved these changes

@jameslamb jameslamb Awaiting requested review from jameslamb jameslamb is a code owner automatically assigned from rapidsai/ci-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KyleFromNVIDIA @bdice @galipremsagar @vyasr