Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add partitioning APIs to pylibcudf #16781

Merged
merged 11 commits into from
Sep 26, 2024
Merged

Add partitioning APIs to pylibcudf #16781

merged 11 commits into from
Sep 26, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Contributes to #15162

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package labels Sep 9, 2024
@mroeschke mroeschke requested a review from a team as a code owner September 9, 2024 22:56
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue and removed pylibcudf Issues specific to the pylibcudf package labels Sep 9, 2024
@mroeschke mroeschke added pylibcudf Issues specific to the pylibcudf package and removed Python Affects Python cuDF API. labels Sep 9, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. and removed pylibcudf Issues specific to the pylibcudf package labels Sep 10, 2024
@mroeschke mroeschke mentioned this pull request Sep 10, 2024
Open
@Matt711 Matt711 added the pylibcudf Issues specific to the pylibcudf package label Sep 19, 2024
vyasr
vyasr requested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions to improve the tests and align them with existing testing patterns. They may also apply to other PRs that you have open.

python/pylibcudf/pylibcudf/tests/test_partitioning.py Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/tests/test_partitioning.py Outdated Show resolved Hide resolved
@vyasr
Copy link
Contributor

vyasr commented Sep 25, 2024

/merge

@rapids-bot rapids-bot bot merged commit b00a718 into rapidsai:branch-24.10 Sep 26, 2024
98 checks passed
@mroeschke mroeschke deleted the pylibcudf/partitioning branch September 26, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matt711 Matt711 Matt711 approved these changes

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @vyasr @Matt711