Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add string.attributes APIs to pylibcudf #16785

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Add string.attributes APIs to pylibcudf #16785

merged 4 commits into from
Sep 25, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Contributes to #15162

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package labels Sep 10, 2024
@mroeschke mroeschke requested a review from a team as a code owner September 10, 2024 19:05
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue and removed pylibcudf Issues specific to the pylibcudf package labels Sep 10, 2024
@mroeschke mroeschke mentioned this pull request Sep 10, 2024
Open
@Matt711 Matt711 added the pylibcudf Issues specific to the pylibcudf package label Sep 19, 2024
vyasr
vyasr requested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a doc update.

python/pylibcudf/pylibcudf/strings/__init__.pxd Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/strings/__init__.py Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/strings/attributes.pyx Outdated Show resolved Hide resolved
@Matt711 Matt711 added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Sep 25, 2024
@vyasr
Copy link
Contributor

vyasr commented Sep 25, 2024

/merge

@rapids-bot rapids-bot bot merged commit c7f6a22 into rapidsai:branch-24.10 Sep 25, 2024
113 checks passed
@mroeschke mroeschke deleted the pylibcudf/strings/attributes branch September 26, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@Matt711 Matt711 Matt711 approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
pylibcudf
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @vyasr @Matt711