Build cudf-polars with build.sh
#16898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon-b-miller
added
feature request
| if buildAll || hasArg cudf_polars; then | ||
|
|
||
| cd ${REPODIR}/python/cudf_polars | ||
| python ${PYTHON_ARGS_FOR_INSTALL} . |
There was a problem hiding this comment.
This doesn't install polars itself. Should dependencies.yaml be updated somehow such that polars is present the conda environments we often use to build from source, in the same way dask is present for instance?
There was a problem hiding this comment.
Yes, I did this in #16875. Merge that first, or merge it into this PR.
There was a problem hiding this comment.
ah, thanks @bdice . Let's get that one in and this one afterwards.
galipremsagar
approved these changes
Sep 25, 2024
AyodeAwe
approved these changes
Sep 25, 2024
|
/merge |
galipremsagar
added
the
5 - Ready to Merge
|
/merge |
rapids-bot
bot
merged commit ef27082
into
rapidsai:branch-24.10
109 of 119 checks passed
rjzamora
pushed a commit
to rjzamora/cudf
that referenced
this pull request
Sep 25, 2024
This PR adds `cudf-polars` to the top level build script. Authors: - https://github.com/brandon-b-miller - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Jake Awe (https://github.com/AyodeAwe) URL: rapidsai#16898
Matt711
pushed a commit
to mroeschke/cudf
that referenced
this pull request
Sep 25, 2024
This PR adds `cudf-polars` to the top level build script. Authors: - https://github.com/brandon-b-miller - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Jake Awe (https://github.com/AyodeAwe) URL: rapidsai#16898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
cudf-polarsto the top level build script.