Fix links in Dask cuDF documentation #16929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjzamora
commented
Sep 26, 2024
Comment on lines
-301
to
+300
| * `Use native cuDF spilling whenever possible <Enable cuDF Spilling>`_ | ||
| * Use a distributed cluster with `Dask-CUDA <https://docs.rapids.ai/api/dask-cuda/stable/>`__ workers |
There was a problem hiding this comment.
I'm honestly not sure how to properly link to a different section within this page, so I'm just linking to the dask-cuda docs, etc. Happy to revise if others have advice.
There was a problem hiding this comment.
You can do inter-page links with syntax like this: https://www.sphinx-doc.org/en/master/usage/referencing.html#cross-referencing-syntax. No need to wait for this right now though.
There was a problem hiding this comment.
I just did that for this page, we can do that more broadly in 24.12
rjzamora
commented
Sep 26, 2024
Comment on lines
304
to
306
| * Avoid shuffling whenever possible | ||
| * Use ``split_out=1`` for low-cardinality groupby aggregations | ||
| * Use ``broadcast=True`` for joins when at least one collection comprises a small number of partitions (e.g. ``<=5``) | ||
|
|
||
| * Use ``split_out=1`` for low-cardinality groupby aggregations |
There was a problem hiding this comment.
Not completely sure how to get a nested list to render "correctly"
galipremsagar
approved these changes
Sep 26, 2024
vyasr
approved these changes
Sep 26, 2024
galipremsagar
added
the
5 - Ready to Merge
|
/merge |
|
Thanks so much for your help with this @galipremsagar ! |
copy-pr-bot bot
pushed a commit
that referenced
this pull request
Sep 28, 2024
More follow-up fixes to the recent Dask-cuDF documentation additions. Authors: - Richard (Rick) Zamora (https://github.com/rjzamora) - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Vyas Ramasubramani (https://github.com/vyasr) URL: #16929
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More follow-up fixes to the recent Dask-cuDF documentation additions.