Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-tidy fixes part 2 #16938

Merged
merged 2 commits into from
Sep 27, 2024
Merged

clang-tidy fixes part 2 #16938

merged 2 commits into from
Sep 27, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Sep 26, 2024

Description

Subset of improvements to the code base proposed by the latest version of clang-tidy.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 26, 2024
@vyasr vyasr self-assigned this Sep 26, 2024
@vyasr vyasr requested a review from a team as a code owner September 26, 2024 23:37
@vyasr vyasr requested review from zpuller and vuule September 26, 2024 23:37
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 26, 2024
vuule
vuule reviewed Sep 26, 2024
View reviewed changes
cpp/src/io/avro/avro.cpp Outdated Show resolved Hide resolved
@vyasr vyasr requested a review from vuule September 27, 2024 14:34
@vyasr
Copy link
Contributor Author

vyasr commented Sep 27, 2024

/merge

@rapids-bot rapids-bot bot merged commit afe9f92 into rapidsai:branch-24.12 Sep 27, 2024
100 checks passed
@vyasr vyasr deleted the feat/clang_tidy_src branch September 27, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@zpuller zpuller Awaiting requested review from zpuller zpuller is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vyasr vyasr

Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyasr @vuule