-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Migrate nvtext/edit_distance APIs to pylibcudf #16957
Merged
rapids-bot
merged 3 commits into
rapidsai:branch-24.12
from
Matt711:pylibcudf-nvtext-edit_distance
Oct 4, 2024
Merged
[FEA] Migrate nvtext/edit_distance APIs to pylibcudf #16957
rapids-bot
merged 3 commits into
rapidsai:branch-24.12
from
Matt711:pylibcudf-nvtext-edit_distance
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt711
added
feature request
New feature or request
non-breaking
Non-breaking change
labels
Sep 30, 2024
github-actions
bot
added
libcudf
Affects libcudf (C++/CUDA) code.
Python
Affects Python cuDF API.
CMake
CMake build issue
pylibcudf
Issues specific to the pylibcudf package
labels
Sep 30, 2024
Matt711
commented
Sep 30, 2024
Matt711
changed the title
[WIP] Migrate nvtext/edit_distance APIs to pylibcudf
[FEA] Migrate nvtext/edit_distance APIs to pylibcudf
Oct 1, 2024
mroeschke
reviewed
Oct 3, 2024
mroeschke
reviewed
Oct 3, 2024
mroeschke
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modifications can be done in a follow up, but LGTM
PointKernel
approved these changes
Oct 4, 2024
davidwendt
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C++ approval
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CMake
CMake build issue
feature request
New feature or request
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
pylibcudf
Issues specific to the pylibcudf package
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apart of #15162. This PR migrates
edit_distance.pxd
to pylibcudfChecklist