Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add string.convert.convert_datetime/convert_booleans APIs to pylibcudf #16971

Merged
merged 14 commits into from
Oct 4, 2024
Merged

Add string.convert.convert_datetime/convert_booleans APIs to pylibcudf #16971

merged 14 commits into from
Oct 4, 2024

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Oct 2, 2024 •
edited
Loading

Description

Contributes to #15162

Also address a review in #16935 (comment)

This also modifies some format arguments in convert_datetime.pyx to accept str instead of bytes (const string&) to align more with Python. Let me know if you prefer to change this back

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package labels Oct 2, 2024
@mroeschke mroeschke requested a review from a team as a code owner October 2, 2024 01:29
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue labels Oct 2, 2024
@mroeschke mroeschke mentioned this pull request Oct 2, 2024
Open
@mroeschke mroeschke mentioned this pull request Oct 2, 2024
Merged
3 tasks
@mroeschke mroeschke mentioned this pull request Oct 2, 2024
Merged
3 tasks
@github-actions github-actions bot added the cudf.polars Issues specific to cudf.polars label Oct 3, 2024
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit efaa0b5 into rapidsai:branch-24.12 Oct 4, 2024
99 checks passed
@mroeschke mroeschke deleted the pylibcudf/strings/convert1 branch October 4, 2024 18:20
rapids-bot bot pushed a commit that referenced this pull request Oct 4, 2024
@mroeschke
Add docstrings and test for strings.convert_durations APIs for pylibc…
77f3a5d 
…udf (#16982)

Contributes to #15162

Since the implementation already existed:

* Added docstrings
* Like #16971, made the `format` parameter accept `str` instead
* Aligned parameter names closer to pylibcudf
* Added missing `move`s
* Moved `convert_duration` tests to `test_string_convert_duration.py` and added a new test for `from_durations`

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #16982
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
CMake CMake build issue cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @vyasr