Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add string.convert.convert_fixed_type APIs to pylibcudf #16984

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Add string.convert.convert_fixed_type APIs to pylibcudf #16984

merged 3 commits into from
Oct 4, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Contributes to #15162

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package labels Oct 3, 2024
@mroeschke mroeschke requested a review from a team as a code owner October 3, 2024 00:22
@mroeschke mroeschke requested review from wence- and bdice October 3, 2024 00:22
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue labels Oct 3, 2024
@mroeschke mroeschke mentioned this pull request Oct 3, 2024
Open
vyasr
vyasr approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a question about the pxd, but I don't need to review again.

python/pylibcudf/pylibcudf/strings/convert/__init__.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a corresponding pxd file? If not, can we add it? If so, can we update it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes we have one and forgot to update.

@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 119aa9d into rapidsai:branch-24.12 Oct 4, 2024
99 checks passed
@mroeschke mroeschke deleted the pylibcudf/strings/convert_fixed_point branch October 4, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @vyasr