Migrate nvtext generate_ngrams APIs to pylibcudf #17006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt711
added
feature request
github-actions
bot
added
Python
…/cudf into pylibcudf-nvtext-generate_ngrams
|
/ok to test |
mroeschke
reviewed
Oct 7, 2024
Comment on lines
17
to
18
| <size_type> ngrams, | ||
| <plc_Scalar> py_separator.device_value.c_value |
There was a problem hiding this comment.
I think we don't need these explicit casts. I believe Cython will implicitly perform the valid cast if needed
There was a problem hiding this comment.
Thanks, I'll try and build without them. I wonder--in general where you can get away with not explicitly casting?
Matt711
commented
Oct 7, 2024
|
/ok to test |
bdice
approved these changes
Oct 7, 2024
python/pylibcudf/pylibcudf/tests/test_nvtext_generate_ngrams.py
Outdated
Show resolved
Hide resolved
|
/ok to test |
|
/merge |
Matt711
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apart of #15162
Checklist