Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate NVText Stemming APIs to pylibcudf #17085

Merged
merged 30 commits into from
Oct 24, 2024
Merged

Migrate NVText Stemming APIs to pylibcudf #17085

merged 30 commits into from
Oct 24, 2024

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Oct 15, 2024 •
edited
Loading

Description

Apart of #15162

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Matt711 and others added 22 commits October 6, 2024 13:49
@Matt711
Migrate nvtext generate_ngrams APIs to pylibcudf
7a0e19f
@Matt711
Migrate nvtext jaccard API to pylibcudf
82aaabb
@Matt711
Merge branch 'branch-24.12' into pylibcudf-nvtext-jaccard
e51dfb1
@Matt711
comment out test
1db10e6
@Matt711
Merge branch 'branch-24.12' into pylibcudf-nvtext-jaccard
2c0534c
@Matt711
add a test
af71a5b
@Matt711
merge conflict
b8f8d7d
@Matt711
clean up
860835d
@Matt711
Migrate Min Hashing APIs to pylibcudf
5e5cd03
@Matt711
merge conflict
cfbda56
@Matt711
clean up, add missing tests
bfa583e
@Matt711
Merge branch 'branch-24.12' into pylibcudf-nvtext-minhash
2584241
@Matt711
[WIP] Migrate remaining nvtext NGrams APIs to pylibcudf
c67b737
@Matt711
merge conflict
5033f2c
@Matt711
initial commit
e536b89
@Matt711
clean up
335803c
@Matt711
oops deleted the conda envs?
42228eb
@Matt711
remove device_span
94cd3b1
@Matt711
Merge branch 'pylibcudf-nvtext-ngrams_tokenize' of github.com:Matt711…
8614bd7 
…/cudf into pylibcudf-nvtext-normalize
@Matt711
clean up
37c9107
@Matt711
fix typo
6de3871
@Matt711
[WIP] Migrate NVText Stemming APIs to pylibcudf
6e47499
@Matt711 Matt711 added feature request New feature or request non-breaking Non-breaking change labels Oct 15, 2024
@Matt711 Matt711 self-assigned this Oct 15, 2024
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 15, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue pylibcudf Issues specific to the pylibcudf package labels Oct 15, 2024
@Matt711
Copy link
Contributor Author

Matt711 commented Oct 22, 2024

/ok to test

@Matt711 Matt711 changed the title [WIP] Migrate NVText Stemming APIs to pylibcudf Migrate NVText Stemming APIs to pylibcudf Oct 22, 2024
@Matt711 Matt711 marked this pull request as ready for review October 22, 2024 14:25
@Matt711 Matt711 requested a review from a team as a code owner October 22, 2024 14:25
bdice
bdice requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions. Generally looks good.

python/cudf/cudf/_lib/nvtext/stemmer.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_lib/nvtext/stemmer.pyx Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/nvtext/__init__.pxd Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/nvtext/stemmer.pyx Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/tests/test_nvtext_stemmer.py Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/tests/test_nvtext_stemmer.py Outdated Show resolved Hide resolved
@Matt711
Copy link
Contributor Author

Matt711 commented Oct 22, 2024

/ok to test

@Matt711
Copy link
Contributor Author

Matt711 commented Oct 22, 2024

/ok to test

@Matt711 Matt711 requested a review from bdice October 22, 2024 23:35
@Matt711
Copy link
Contributor Author

Matt711 commented Oct 22, 2024

/ok to test

bdice
bdice reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a couple of minor C++ improvements to pair with this PR.

python/pylibcudf/pylibcudf/nvtext/stemmer.pyx Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/tests/test_nvtext_stemmer.py Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/libcudf/nvtext/stemmer.pxd Outdated Show resolved Hide resolved
@Matt711 Matt711 requested a review from a team as a code owner October 23, 2024 21:03
@Matt711 Matt711 requested review from vuule and lamarrr October 23, 2024 21:03
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 23, 2024
@Matt711
Copy link
Contributor Author

Matt711 commented Oct 23, 2024

/ok to test

@Matt711 Matt711 requested a review from bdice October 23, 2024 21:10
@Matt711
Copy link
Contributor Author

Matt711 commented Oct 23, 2024

/merge

@rapids-bot rapids-bot bot merged commit d7cdf44 into rapidsai:branch-24.12 Oct 24, 2024
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@vuule vuule Awaiting requested review from vuule vuule is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@lamarrr lamarrr Awaiting requested review from lamarrr lamarrr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@Matt711 Matt711

Labels
CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matt711 @bdice