Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor I/O code quality improvements #17105

Merged

Conversation

kingcrimsontianyu
Copy link
Contributor

@kingcrimsontianyu kingcrimsontianyu commented Oct 16, 2024

Description

This PR makes small improvements for the I/O code. Specifically,

  • Place type constraint on a template class to allow only for rvalue argument. In addition, replace std::move with std::forward to make the code more apparently consistent with the convention, i.e. use std::move() on the rvalue references, and std::forward on the forwarding references (Effective modern C++ item 25).
  • Alleviate (but not completely resolve) an existing cuFile driver close issue by removing the explicit driver close call. See [BUG] cuFile driver closing causes segfault upon program termination #17121
  • Minor typo fix (structclass).

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@kingcrimsontianyu kingcrimsontianyu self-assigned this Oct 16, 2024
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 16, 2024
@kingcrimsontianyu kingcrimsontianyu added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed libcudf Affects libcudf (C++/CUDA) code. labels Oct 16, 2024
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 17, 2024
@kingcrimsontianyu kingcrimsontianyu changed the title Slightly improve code quality Slightly improve I/O code quality Oct 17, 2024
@kingcrimsontianyu kingcrimsontianyu force-pushed the small_improvements branch 4 times, most recently from 8c7c6dc to 509965b Compare October 24, 2024 01:35
@kingcrimsontianyu kingcrimsontianyu marked this pull request as ready for review October 30, 2024 04:34
@kingcrimsontianyu kingcrimsontianyu requested a review from a team as a code owner October 30, 2024 04:34
@kingcrimsontianyu kingcrimsontianyu changed the title Slightly improve I/O code quality Minor I/O code quality improvements Oct 31, 2024
@kingcrimsontianyu
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 8219d28 into rapidsai:branch-24.12 Nov 1, 2024
113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants