-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor I/O code quality improvements #17105
Merged
rapids-bot
merged 9 commits into
rapidsai:branch-24.12
from
kingcrimsontianyu:small_improvements
Nov 1, 2024
Merged
Minor I/O code quality improvements #17105
rapids-bot
merged 9 commits into
rapidsai:branch-24.12
from
kingcrimsontianyu:small_improvements
Nov 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingcrimsontianyu
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
and removed
libcudf
Affects libcudf (C++/CUDA) code.
labels
Oct 16, 2024
kingcrimsontianyu
changed the title
Slightly improve code quality
Slightly improve I/O code quality
Oct 17, 2024
kingcrimsontianyu
force-pushed
the
small_improvements
branch
4 times, most recently
from
October 24, 2024 01:35
8c7c6dc
to
509965b
Compare
vuule
reviewed
Oct 29, 2024
vuule
reviewed
Oct 29, 2024
kingcrimsontianyu
force-pushed
the
small_improvements
branch
from
October 30, 2024 04:20
509965b
to
a3f1ea4
Compare
vuule
reviewed
Oct 31, 2024
ttnghia
approved these changes
Oct 31, 2024
vuule
approved these changes
Oct 31, 2024
kingcrimsontianyu
changed the title
Slightly improve I/O code quality
Minor I/O code quality improvements
Oct 31, 2024
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
Improvement / enhancement to an existing function
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes small improvements for the I/O code. Specifically,
std::move
withstd::forward
to make the code more apparently consistent with the convention, i.e. usestd::move()
on the rvalue references, andstd::forward
on the forwarding references (Effective modern C++ item 25).struct
→class
).Checklist