Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use libcudf_exception_handler throughout pylibcudf.libcudf #17109

Merged
merged 8 commits into from
Nov 20, 2024
Merged

Use libcudf_exception_handler throughout pylibcudf.libcudf #17109

merged 8 commits into from
Nov 20, 2024

Conversation

brandon-b-miller
Copy link
Contributor

Closes #17036

(WIP, generated by a quick sed script)

@github-actions github-actions bot added Python Affects Python cuDF API. pylibcudf Issues specific to the pylibcudf package labels Oct 17, 2024
@brandon-b-miller brandon-b-miller added feature request New feature or request non-breaking Non-breaking change labels Oct 17, 2024
@vyasr
Copy link
Contributor

vyasr commented Nov 13, 2024

@brandon-b-miller do you want to refresh this PR? Even if it doesn't capture everything, I figure we might as well merge whatever it does capture then do a second pass later?

@brandon-b-miller brandon-b-miller marked this pull request as ready for review November 20, 2024 17:56
@brandon-b-miller brandon-b-miller requested a review from a team as a code owner November 20, 2024 17:56
vyasr
vyasr approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spot-checked but didn't go through all the files, but I'm trusting that if tests pass we are fine here.

@vyasr
Copy link
Contributor

vyasr commented Nov 20, 2024

/merge

@rapids-bot rapids-bot bot merged commit 2e88835 into rapidsai:branch-24.12 Nov 20, 2024
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@vyasr vyasr

@brandon-b-miller brandon-b-miller

Labels
feature request New feature or request non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Use except +libcudf_exception_handler for all Cython function declarations in pylibcudf/libcudf
2 participants
@brandon-b-miller @vyasr