Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clang-tidy violations for span.hpp and hostdevice_vector.hpp #17124

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fix clang-tidy violations for span.hpp and hostdevice_vector.hpp #17124

merged 1 commit into from
Oct 18, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Errors reported here: https://github.com/rapidsai/cudf/actions/runs/11398977412/job/31716929242
Just adding [[nodiscard]] to a few member functions.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 18, 2024
@davidwendt davidwendt self-assigned this Oct 18, 2024
@davidwendt davidwendt requested a review from a team as a code owner October 18, 2024 14:03
@davidwendt davidwendt requested review from shrshi and ttnghia October 18, 2024 14:03
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit e1c9a5a into rapidsai:branch-24.12 Oct 18, 2024
102 checks passed
@davidwendt davidwendt deleted the tidy-hv-span branch October 18, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@shrshi shrshi shrshi approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @shrshi @ttnghia