Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added strings AST vs BINARY_OP benchmarks #17128

Merged
merged 26 commits into from
Oct 28, 2024
Merged

Added strings AST vs BINARY_OP benchmarks #17128

merged 26 commits into from
Oct 28, 2024

Conversation

lamarrr
Copy link
Contributor

@lamarrr lamarrr commented Oct 18, 2024 •
edited
Loading

Description

This merge request implements benchmarks to compare the strings AST and BINARY_OPs. It also moves out the common string input generator function to a common benchmarks header as it is repeated across other benchmarks.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 18, 2024
@lamarrr lamarrr added feature request New feature or request non-breaking Non-breaking change labels Oct 18, 2024
@lamarrr lamarrr marked this pull request as ready for review October 18, 2024 19:26
@lamarrr lamarrr requested a review from a team as a code owner October 18, 2024 19:26
@lamarrr lamarrr requested review from bdice and PointKernel October 18, 2024 19:26
PointKernel
PointKernel reviewed Oct 18, 2024
View reviewed changes
cpp/benchmarks/binaryop/binaryop.cpp Outdated Show resolved Hide resolved
cpp/benchmarks/common/generate_input.hpp Outdated Show resolved Hide resolved
cpp/benchmarks/binaryop/binaryop.cpp Outdated Show resolved Hide resolved
cpp/benchmarks/common/generate_input.cu Outdated Show resolved Hide resolved
bdice
bdice reviewed Oct 21, 2024
View reviewed changes
cpp/benchmarks/ast/transform.cpp Outdated Show resolved Hide resolved
cpp/benchmarks/ast/transform.cpp Outdated Show resolved Hide resolved
cpp/benchmarks/ast/transform.cpp Outdated Show resolved Hide resolved
cpp/benchmarks/ast/transform.cpp Outdated Show resolved Hide resolved
cpp/benchmarks/binaryop/binaryop.cpp Outdated Show resolved Hide resolved
cpp/benchmarks/binaryop/binaryop.cpp Outdated Show resolved Hide resolved
cpp/benchmarks/common/generate_input.cu Outdated Show resolved Hide resolved
lamarrr and others added 10 commits October 22, 2024 09:30
@lamarrr @bdice
refactored chars_size accumulation
2565339 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@lamarrr @bdice
removed checked indexing
27b7c79 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@lamarrr @bdice
refactored chars_size accumulation
e6f7d53 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@lamarrr @bdice
removed checked indexing
10f82c2 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@lamarrr @bdice
fixed possible overflow for calculating string matches
ef6763d 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@lamarrr
fixed code formatting
533dfa0
@lamarrr
added assert for checking comparison count
0626aaf
@lamarrr
fixed chars_size calculation
94d392b
@lamarrr
parameterized string comparison benchmarks comparison and reduce oper…
5add488 
…ators
@lamarrr
parameterized string comparison benchmarks comparison and reduce oper…
5e506a3 
…ators
@GregoryKimball
Copy link
Contributor

@davidwendt would you also please take a look?

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 26, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@lamarrr
Copy link
Contributor Author

lamarrr commented Oct 28, 2024

/ok to test

@lamarrr
Copy link
Contributor Author

lamarrr commented Oct 28, 2024

/ok to test

@lamarrr
Copy link
Contributor Author

lamarrr commented Oct 28, 2024

/merge

@rapids-bot rapids-bot bot merged commit 4c04b7c into rapidsai:branch-24.12 Oct 28, 2024
102 checks passed
@lamarrr lamarrr deleted the strings-benchmarks branch October 28, 2024 21:15
@bdice bdice mentioned this pull request Jan 13, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@PointKernel PointKernel PointKernel approved these changes

@bdice bdice Awaiting requested review from bdice

Assignees
No one assigned
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lamarrr @GregoryKimball @bdice @PointKernel @davidwendt