Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async execution policy for true_if #17146

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

PointKernel
Copy link
Member

@PointKernel PointKernel commented Oct 22, 2024

Description

Closes #17117

Related to #12086

This PR replaces the synchronous execution policy with an asynchronous one to eliminate unnecessary synchronization.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel added Performance Performance related issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 22, 2024
@PointKernel PointKernel self-assigned this Oct 22, 2024
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 22, 2024
@PointKernel PointKernel marked this pull request as ready for review October 22, 2024 22:56
@PointKernel PointKernel requested a review from a team as a code owner October 22, 2024 22:56
@PointKernel PointKernel added the 3 - Ready for Review Ready for review by team label Oct 22, 2024
@davidwendt davidwendt requested review from jlowe, davidwendt and a team October 22, 2024 23:20
@PointKernel
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 02ee819 into rapidsai:branch-24.12 Oct 23, 2024
112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Performance Performance related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Unnecessary stream synchronization in cudf::is_valid
5 participants