Replace FindcuFile with upstream FindCUDAToolkit support #17298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake's FindCUDAToolkit has supported cuFile since 3.25. Use this support and remove the custom FindcuFile module.
KyleFromNVIDIA
added
improvement
github-actions
bot
added
libcudf
bdice
approved these changes
Nov 12, 2024
bdice
reviewed
Nov 12, 2024
bdice
approved these changes
Nov 12, 2024
karthikeyann
approved these changes
Nov 12, 2024
PointKernel
approved these changes
Nov 12, 2024
vuule
reviewed
Nov 12, 2024
mhaseeb123
approved these changes
Nov 12, 2024
|
/merge |
KyleFromNVIDIA
added a commit
to KyleFromNVIDIA/cudf
that referenced
this pull request
Nov 13, 2024
The reference in JNI was missed in rapidsai#17298. Replace it with FindCUDAToolkit.
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
The reference in JNI was missed in #17298. Replace it with `FindCUDAToolkit`. Also backport `FindCUDAToolkit` from CMake 3.31 to get https://gitlab.kitware.com/cmake/cmake/-/commit/b38a8e77cb3c8401b3022a68f07a4fd77b290524. Also add an option to statically link `cuFile`. Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Bradley Dice (https://github.com/bdice) - Nghia Truong (https://github.com/ttnghia) - Vyas Ramasubramani (https://github.com/vyasr) - Gera Shegalov (https://github.com/gerashegalov) URL: #17315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CMake's
FindCUDAToolkithas supported cuFile since 3.25. Use this support and remove the customFindcuFilemodule.Checklist