Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cmake to 3.28.6 in JNI Dockerfile #17342

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Update cmake to 3.28.6 in JNI Dockerfile #17342

merged 1 commit into from
Nov 15, 2024

Conversation

jlowe
Copy link
Contributor

@jlowe jlowe commented Nov 15, 2024

Description

Updates cmake to 3.28.6 in the JNI Dockerfile used to build the cudf jar. This helps avoid a bug in older cmake where FindCUDAToolkit can fail to find cufile libraries.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jlowe jlowe added Java Affects Java cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 15, 2024
@jlowe jlowe self-assigned this Nov 15, 2024
@jlowe jlowe requested a review from a team as a code owner November 15, 2024 20:40
@jlowe jlowe added bug Something isn't working and removed improvement Improvement / enhancement to an existing function labels Nov 15, 2024
@jlowe jlowe mentioned this pull request Nov 15, 2024
Merged
@jlowe
Copy link
Contributor Author

jlowe commented Nov 15, 2024

/merge

gerashegalov
gerashegalov approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rapids-bot rapids-bot bot merged commit e683647 into rapidsai:branch-24.12 Nov 15, 2024
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@gerashegalov gerashegalov gerashegalov approved these changes

Assignees

@jlowe jlowe

Labels
bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlowe @gerashegalov @ttnghia